file:// protocol support

[stevenvachon]

It'd be convenient to not have to handle this ourselves each time we need it.

Use cases:

• Requesting data from URLs in an HTML document where such a protocol is most likely to occur

[sindresorhus]

Why? Please include a issue description.

[stevenvachon]

Original comment updated.

[sindresorhus]

Haven't had a chance to think this through yet, but sounds like a pretty good venue for security issues.

fetch() intentionally doesn't support file://.

[stevenvachon]

file:// is part of the fetch() spec: https://fetch.spec.whatwg.org/#basic-fetch

[sindresorhus]

Please read the actual text there about it.

[stevenvachon]

Make it optional, then. That way, we could do something like:

const baseUrl = new URL("http://domain/")
const url = new URL("file://dir/file", baseUrl)
got(url, { supportFileProtocol: baseUrl.protocol==="file:" })  // origin error

[stevenvachon]

Now that I think of it, a separate package should be written to handle this as it can then be used with any similar request library. If we want, we can document its use in this package's readme.

[tommedema]

@stevenvachon are you aware of any such package?

[stevenvachon]

@tommedema no, but I also haven't begun to use this library yet either.

[sindresorhus]

Going to pass on this. See node-fetch/node-fetch#75 (comment) for reasoning.

[szmarczak]

I don't think it's a good idea, it could lead to potential security issues.