Upgrade dev dependencies #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Sure, go ahead with the refactor. |
iamnapo
changed the title
sindresorhus
reviewed
Oct 2, 2020
Co-authored-by: Sindre Sorhus <[email protected]>
sindresorhus
changed the title
Owner
|
Thanks :) |
andi1984
reviewed
Jan 8, 2021
andi1984
left a comment
andi1984
left a comment
There was a problem hiding this comment.
IMHO there was a bug slipping through in a try-catch block which breaks now the latest release version 3.0.2.
| try { | ||
| stat = fs.statSync(options.cwd); | ||
| } catch (_) { | ||
| } catch { |
There was a problem hiding this comment.
@sindresorhus I think this issue slipped through with the removed brackets which fails now in the latest 3.0.2 version. Should I make a PR for fixing it?
Owner
Repository owner
locked and limited conversation to collaborators
Jan 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.writeFileSync).