Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 8 doesn't match relative files up the directory #80

Closed
dpopp07 opened this issue Apr 4, 2018 · 4 comments
Closed

Version 8 doesn't match relative files up the directory #80

dpopp07 opened this issue Apr 4, 2018 · 4 comments

Comments

@dpopp07
Copy link

dpopp07 commented Apr 4, 2018

My project structure

/project
    /src
        - index.js (`globby` is used in this code)
    /files
        - foo.json
        - bar.json

Behavior in v7.1.1

const matches = await globby(['../files/foo.json', '../files/bar.json']);
console.log(matches);
// Output: ['../files/foo.json', '../files/bar.json']

Behavior in v8.0.1

const matches = await globby(['../files/foo.json', '../files/bar.json']);
console.log(matches);
// Output: [ ]

I know these aren't exactly globs but sometimes pure file paths get passed in and I need to globby to return them if they exist. Is this intended behavior, to only support files at the same or lower levels of the file structure?

Node version: 8.9.4

@sindresorhus
Copy link
Owner

// @mrmlnc

@mrmlnc
Copy link
Contributor

mrmlnc commented Apr 9, 2018

Confirm. This is will be fixed in the mrmlnc/fast-glob#93 issue in the fast-glob package.

@mrmlnc
Copy link
Contributor

mrmlnc commented Apr 22, 2018

Fixed by [email protected].

@sindresorhus
Copy link
Owner

🙌🦄🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants