Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce alphabetical order for supported file types list #511

Closed
sindresorhus opened this issue Dec 16, 2021 · 1 comment · Fixed by #531
Closed

Enforce alphabetical order for supported file types list #511

sindresorhus opened this issue Dec 16, 2021 · 1 comment · Fixed by #531

Comments

@sindresorhus
Copy link
Owner

I don't want it alphabetical until we have some kind simple script that can enforce it. Otherwise, I'm stuck having to comment about the order on every other pull request.

https://github.com/sindresorhus/file-type#supported-file-types

@votruongan
Copy link
Contributor

votruongan commented Dec 25, 2021

I think that you can sort the Supported file types in readme.md once, and write a test to ensure the Supported file types in readme.md is alphabetically ordered. From then on, every PR will have the description line in the readme.md placed appropriately by the author themself. After that, their PR will be checked by the your written test.

Just like how npm enforces alphabetical order: https://github.com/npm/npm-expansions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants