-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically wait for file streams to open #82
Comments
We could detect the follow custom properties attached to it:
Maybe we should add |
I just made |
Even better. Less bloat for |
This is a great idea. Makes working with file streams much easier. I will have a look at implementing this. |
I think we should also at least try to get this into Node.js core by opening an issue argumenting it's the expected behavior. |
Good point. We probably all know how this will end but at least we can try. |
At least we can then reference Node.js' unwillingness to good UX. It's always worth trying to improve core Node.js if possible, as it benefits of lot more users, and of course less code for us to maintain. |
Totally agree with that. |
Basically, they only allow streams that have file descriptors, and under the hood, they convert streams to those file descriptors. It would have been way less confusing for them not to allow streams, and just provide a Streams passed to |
Yup |
This feature has been just fixed in Execa 9.0.0. Please see (and share!) the release post and the changelog. Please see more information here. |
It might be possible to wait for the
open
event on file streams (if we can find a way to detect that a stream is in fact a file stream, and that it will indeed eventually open).See the discussion here
The text was updated successfully, but these errors were encountered: