saveAs option doesn't work

[iamisti]

const win = BrowserWindow.getFocusedWindow();

const userDocumentPath = app.getPath("documents");
const pathToDestinationDir = `${userDocumentPath}/customfolder/${folder}`;

await download(win, url, {
    saveAs: true,
});

no matter what I do, i dont get the save as dialog. The file just directly gets downloaded into my download folder. Anyone knows why?

[papb]

I assume you have const { download } = require('electron-dl') somewhere, right?

[theogravity]

The electron-dl library uses setSaveDialogOptions() to show the "Save As" dialog which is what Electron believes you should use, but it is extremely buggy:

electron/electron#41640

Basically when you use it to show the save dialog, the download will continue in the background along with firing all the events associated with it.

I did find a workaround and wrote my own library to address that where events will only fire after the user has confirmed or denied the dialog:

https://github.com/theogravity/electron-dl-manager