Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referer should be configurable #74

Open
JaimeObregon opened this issue Jan 30, 2021 · 1 comment
Open

Referer should be configurable #74

JaimeObregon opened this issue Jan 30, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@JaimeObregon
Copy link

Puppeteer's page.goto options are currently hardcoded:

	await page[isHTMLContent ? 'setContent' : 'goto'](input, {
		timeout: timeoutInSeconds,
		waitUntil: 'networkidle2'
	});

But certain pages, such as news articles from ft.com, display different content depending on the user request' referer header.

I'd suggest exposing page.goto options as a configurable object.

@sindresorhus
Copy link
Owner

I think it's better to just expose a referer option.

@sindresorhus sindresorhus added enhancement New feature or request help wanted Extra attention is needed labels Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants