Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-exists doesn't detect Applications in the User's local directory #5

Closed
WorkInProgress-Development opened this issue May 19, 2021 · 1 comment

Comments

@WorkInProgress-Development
Copy link

WorkInProgress-Development commented May 19, 2021

Issue occurs as part of PR #4, and discovered whilst investigating will-stone/browserosaurus#399
The error is specifically on line 10 of index.js, as node does not expand tildes (nodejs/node#684).
From my limited understanding of node, and testing locally, process.env.HOME has a function equivalent to the tilde, so this should be an easy fix.
Pull request incoming.

@WorkInProgress-Development
Copy link
Author

WorkInProgress-Development commented May 19, 2021

Alternatively, you could use sindresorhus/untildify.

Edit: which I am now realising is one of your own libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant