Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a custom view to enable fast entry of blood pressures #532

Open
pratul opened this issue Mar 11, 2019 · 12 comments
Open

Build a custom view to enable fast entry of blood pressures #532

pratul opened this issue Mar 11, 2019 · 12 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pratul
Copy link

pratul commented Mar 11, 2019

In apps like Cardio Journal, when you enter a new BP, a "custom keyboard" shows up that big easy-to-tap buttons, no extra keys, and rules to support only valid blood pressure values. We're currently using the standard Android keyboard and a custom view will definitely speed up entering BPs.

@pratul pratul added enhancement New feature or request good first issue Good for newcomers labels Mar 11, 2019
@subbramanil
Copy link

@pratul I have some experience with building keyboards at my work and this shouldn't be too hard. Do you guys have a rough idea of what's keys should be there?

Or

Have you guys thought about using a spinner with valid values for blood pressure?

Something like this: https://github.com/DarkionAvey/SwipeSpinnerWidget

The spinner could be set to default 120/80 or the last reading of the patient to make it easier for the user to update. In this way, you don't need to worry about validating the user entry and also speed up entering BPs as BPs typically shouldn't change far different from last reading/normal(120/80).

@dburka
Copy link

dburka commented May 17, 2019

Thanks for offering to help @subbramanil That's so cool. Our colleague @akshayverma1 is working on a design spec for you and will post it here.

We've considered a spinner as you suggest, but it will be a bit slower than a large optimized numeric keyboard — consider that for new enrolled patients, there will be no baseline BP to start from. And, with some muscle memory, typing 5 digits quickly can be very very fast.

Thanks again, we should have a spec to you soon!

@akshayverma1
Copy link

Hi @subbramanil, thank you for extending your help, we really appreciate it!

Here are the specs:

Please do let me know if there’s anything else you might need. 🙂

@subbramanil
Copy link

subbramanil commented May 22, 2019

Thank you @akshayverma1

Can you change the sharing settings in Zeplin?

Seems like I need to be invited to the project to view the files.

@akshayverma1
Copy link

Hey @subbramanil, sorry about that. I have moved the mockups to Figma and they should now be accessible to you.

@akshayverma1
Copy link

@subbramanil Let me know if there’s anything else I could help you with :)

@dburka
Copy link

dburka commented Jun 17, 2019

@subbramanil Just following up on this. We really appreciate your offer to help with this! Anything we can assist with?

@subbramanil
Copy link

subbramanil commented Jun 17, 2019

@akshayverma1 @dburka Sorry Guys for the delay in the update.

Based on the prototype shared, I built a sample keyboard by modifying one of my old projects. Have few minor challenges regarding the style of the buttons, but should be able to complete it soon.

Since It's only a keyboard, I have been modifying my existing project code. I haven't tried to run the "simple-android" app yet. Will ask for help if I ran into any issues.

@rakesh-barik
Copy link

Hey @akshayverma1 The links for the mock ups are not working, if you don't mind could you please share those again. I am interested to give it a try.

@akshayverma1
Copy link

Thanks for offering to help with this, @rakesh-barik. Here are the links:

@benryder1988
Copy link
Contributor

Hi @akshayverma1, is this custom view improvement still open? I was thinking of taking a look at it if it's still required

@akshayverma1
Copy link

Hey @benryder1988, thanks for asking! I’m not sure, but maybe @dburka or @vinaysshenoy might know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants