Clarified how to update tests/test-helper.js when migrating ember-qunit to v5.x #919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
README
shows the following code snippet to help with upgradingember-qunit
tov5.x
or above:I encountered the following error because I didn't import
QUnit
:In this pull request, I updated the code snippet to show a developer (1) how they are to import
QUnit
andsetup
, and (2) in what recommended order they can callsetup
. I used QUnit DOM's own test helper to decide the recommended order.