Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helpful error for invalid attributes to hasText #59

Merged
merged 1 commit into from
Mar 12, 2018
Merged

Add helpful error for invalid attributes to hasText #59

merged 1 commit into from
Mar 12, 2018

Conversation

spencer516
Copy link
Contributor

@spencer516 spencer516 commented Mar 12, 2018 •
edited by Turbo87
Loading

This adds a helpful error message when passing an invalid attribute to hasText.

Resolves #47

@Turbo87 Turbo87 changed the title add helpful error for invalid attributes to hasText Add helpful error for invalid attributes to hasText Mar 12, 2018
@Turbo87 Turbo87 added the bug label Mar 12, 2018
Turbo87
Turbo87 approved these changes Mar 12, 2018
View reviewed changes
Copy link
Collaborator

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks! 👍

@Turbo87 Turbo87 merged commit 5309aef into mainmatter:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spencer516 @Turbo87