Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add matchesSelector() assertions #208

Merged
merged 14 commits into from
Jan 9, 2019
Merged

Add matchesSelector() assertions #208

merged 14 commits into from
Jan 9, 2019

Conversation

lindem
Copy link
Contributor

@lindem lindem commented Dec 1, 2018

working at #206 please comment

Turbo87
Turbo87 reviewed Dec 7, 2018
View reviewed changes
lib/assertions/matches-selector.ts Outdated Show resolved Hide resolved
lib/assertions/matches-selector.ts Outdated Show resolved Hide resolved
lib/__tests__/matches-selector.ts Outdated Show resolved Hide resolved
lib/__tests__/matches-selector.ts Show resolved Hide resolved
@lindem
Copy link
Contributor Author

lindem commented Dec 8, 2018

Done with it again (for now). I am unsure if the new redundancy in the assertions.ts file is warranted (doesNotMatchSelector and matchesSelector have a lot in common there), but it works and is easy to understand I hope.

Still happy to continue working on it. Thanks for patience.

Turbo87
Turbo87 reviewed Dec 10, 2018
View reviewed changes
Copy link
Collaborator

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, I think this is going in the right direction! 👍

lib/__tests__/does-not-match-selector.ts Outdated Show resolved Hide resolved
@lindem
Copy link
Contributor Author

lindem commented Jan 5, 2019

@Turbo87 I hope this is more what you wanted. I am seemingly unable to resolve the merge conflict in this PR myself (it is not clear that I can do something about it from the page the button leads to, but then, I cannot write to your repository).

Ah, and happy new year.

@lindem
Copy link
Contributor Author

lindem commented Jan 5, 2019

Hah, persistence wins. ☺

@Turbo87 I used prettier in this way after merging (the newly updated) master:

prettier --config .prettierrc.js --write lib/**/*.ts

I figured this out myself and could not find instructions within the project (are there any?), and therefore recommend amending the CONTRIBUTING section the the README.md file accordingly.

Turbo87
Turbo87 approved these changes Jan 9, 2019
View reviewed changes
Copy link
Collaborator

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Turbo87 Turbo87 changed the title Add matchesSelector assertion Add matchesSelector() assertions Jan 9, 2019
@Turbo87 Turbo87 merged commit 08cedfa into mainmatter:master Jan 9, 2019
@timo-lindemann-victors timo-lindemann-victors mentioned this pull request Jan 9, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timo-lindemann-victors timo-lindemann-victors timo-lindemann-victors left review comments

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lindem @Turbo87 @timo-lindemann-victors