Adds support for count option to isVisible assertion
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allows passing { count: N } to isVisible, with similar semantics to how exists supports a `count` option
- refactors `isNotVisible` to be implemented as `isVisible({ count: 0 })`
- introduce private `findElements` method to be used similarly to `this.findElement`
- refactor to use `findElements` in `exists` as well as in `isVisible`
|
BTW, the practical driver for this was working today with a virtual list component where some DOM nodes are kept around with |
Turbo87
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
countoptionisNotVisibleto be implemented asisVisible({ count: 0 })findElementsmethod to be used similarly tothis.findElementfindElementsinexistsas well as inisVisible