Collapse multiple leading and trailing whitespaces into a single whitespace / Does not collapse multiple #16
Conversation
…itespace - Does not collapse multiple into a single whitespace
utils/helpers.js
Outdated
| }; | ||
|
|
||
| const hasLeadingOrTrailingWhiteSpace = function(chars) { | ||
| chars = encodeURIComponent(chars); |
There was a problem hiding this comment.
why are you encoding the characters here?
utils/helpers.js
Outdated
| module.exports = { | ||
| stripWhiteSpace, | ||
| isWhitespaceTextNode, | ||
| WHITESPACE, |
There was a problem hiding this comment.
why do we export this? looks unused 🤔
utils/helpers.js
Outdated
| chars = encodeURIComponent(chars || ''); | ||
| chars = chars.replace(matchHorizontalTABAndNewLineBegin, ' ') | ||
| .replace(matchHorizontalTABAndNewLineEnd, ' '); | ||
| return decodeURIComponent(chars); |
There was a problem hiding this comment.
I've built a similar thing lately for qunit-dom mostly according to the HTML spec. Might make sense to reuse the same implementation here too. (see https://github.com/simplabs/qunit-dom/blob/master/lib/helpers/collapse-whitespace.js)
|
I have made the changes suggested. Please have a look at it. |
utils/helpers.js
Outdated
| return chars.replace(leadingWhiteSpace, ' ').replace(trailingWhiteSpace, ' '); | ||
| }; | ||
|
|
||
| const stripNoMinifyBlocks = function(nodes) { |
There was a problem hiding this comment.
why did you not use the normal function syntax here? (e.g. function stripNoMinifyBlocks(nodes) { ... } instead of the const stripNoMinifyBlocks = function(nodes) { ... })
There was a problem hiding this comment.
No specific reason, since stripNoMinifyBlocks is never going to change. I have used const. Shall I use the normal syntax here?
There was a problem hiding this comment.
yeah, I think that would be best, thanks
values(\n,\t, ,\r)
siva-sundar
force-pushed
the
patch_collapse_leading_and_trailing_whitespace
branch
from
bf775d7
to
5989383
Compare
|
Please let me know if anything else needs to be changed. |
|
thanks :) |
This PR collapses multiple leading and trailing whitespaces into a single whitespace as mentioned below.
Actual content:
Minified content: