Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows FTP servers on Linux to delete files starting with a dot. #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

UltraNamahage
Copy link

@UltraNamahage UltraNamahage commented Dec 2, 2021

Fix #99.

Linux-based FTP servers often consider files starting with a dot to be hidden files.
The "-al" option allows you to retrieve them.
However, it is not included in RFC959.

This option should not work with ftp-srv on win, for example.

@simonh1000
Copy link
Owner

What do you mean by should not work? What will happen on a windows server with your code?

@UltraNamahage
Copy link
Author

@simonh1000 Thanks for looking.
It outputs a lot of this stuff.

{
    "name": "ftp-srv",
    "hostname": "UltraNamahage",
    "pid": 37548,
    "id": "2f31cfc1-c0fe-4ad2-ad33-5058279990db",
    "ip": "127.0.0.1",
    "directive": "LIST",
    "level": 50,
    "err": {
        "message": "ENOENT: no such file or directory, stat 'D:\\Project\\ftp-deploy\\test\\remote\\-al '",
        "name": "Error",
        "stack": "Error: ENOENT: no such file or directory, stat 'D:\\Project\\ftp-deploy\\test\\remote\\-al '",
        "code": "ENOENT"
    },
    "msg": "ENOENT: no such file or directory, stat 'D:\\Project\\ftp-deploy\\test\\remote\\-al '",
    "time": "2021-12-02T10:26:57.176Z",
    "v": 0
}

@simonh1000
Copy link
Owner

but that means your code will break some people's setups?

@UltraNamahage
Copy link
Author

There should be no major problems.
In the worst case, a slowdown in processing speed can be expected.

@simonh1000 simonh1000 self-requested a review December 3, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deleteRemote option doesn't remove .dotfiles
2 participants