Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node_modules folder gets uploaded even though it is excluded #113

Open
stirlingsohn opened this issue Aug 26, 2020 · 2 comments
Open

node_modules folder gets uploaded even though it is excluded #113

stirlingsohn opened this issue Aug 26, 2020 · 2 comments

Comments

@stirlingsohn
Copy link

Is there something wrong with my pattern? Some subfolders and elements in the node modules folder get uploaded despite having excluded it.

include: ["*.**", "dist/*"], exclude: [ "dist/**/*.map", "src", "src/**", "src/**/.*", ".*", "node_modules", "node_modules/**", "node_modules/**/.*", ".git/**" ],

cheers Stirling

@jedikcz
Copy link

jedikcz commented Sep 1, 2020

Hi, I've ran into same troubles and by experimenting a little I've found the trouble is with dot folders in node_modules which are being copied despite the rules.

I'd say, the problem is in node_modules/**/.* pattern. It does exclude only dot files, but not folders.

To exclude even dot folders you have to add node_modules/**/.*/** rule as well.

At least that's what works for me.

@stirlingsohn
Copy link
Author

stirlingsohn commented Sep 1, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants