Use norm instead of abs in generic lu factorization (JuliaLang#34575)

* Use norm instead of abs in generic lu factorization * Add norm for ModInt in tests
simeonschaub · Apr 24, 2020 · ecc0c43 · ecc0c43
1 parent 4c7ae77
commit ecc0c43
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/stdlib/LinearAlgebra/src/lu.jl b/stdlib/LinearAlgebra/src/lu.jl
@@ -140,9 +140,9 @@ function generic_lufact!(A::StridedMatrix{T}, ::Val{Pivot} = Val(true);
             # find index max
             kp = k
             if Pivot
-                amax = abs(zero(T))
+                amax = norm(zero(T))
                 for i = k:m
-                    absi = abs(A[i,k])
+                    absi = norm(A[i,k])
                     if absi > amax
                         kp = i
                         amax = absi

diff --git a/stdlib/LinearAlgebra/test/generic.jl b/stdlib/LinearAlgebra/test/generic.jl
@@ -365,6 +365,8 @@ LinearAlgebra.Transpose(a::ModInt{n}) where {n} = transpose(a)
 
     # Needed for pivoting:
     Base.abs(a::ModInt{n}) where {n} = a
+    LinearAlgebra.norm(a::ModInt{n}) where {n} = a
+
     Base.:<(a::ModInt{n}, b::ModInt{n}) where {n} = a.k < b.k
 
     @test A*(lu(A, Val(true))\b) == b