Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing a field type redirects you to edit field. #767

Closed
chtombleson opened this issue May 7, 2018 · 4 comments
Closed

Changing a field type redirects you to edit field. #767

chtombleson opened this issue May 7, 2018 · 4 comments

Comments

@chtombleson
Copy link

When changing a field type using the dropdown it redirects you to edit that fields settings, which makes it nearly impossible to change the field type.

Userforms version: 5.1.1

@robbieaverill
Copy link
Contributor

robbieaverill commented Jun 1, 2018

Cannot reproduce using userforms 5.1.1 on Chrome 66, what browser are you using @chtombleson?

@chtombleson
Copy link
Author

I'm using Chrome 67

@Valandur
Copy link

Valandur commented Jul 5, 2018

Using Silverstripe 4.1.2 and UserForms 5.2.0

I'm having the same issue, along with another issue where the "Add" button on the detail form of a Dropdown Field doesn't work. I believe I have a way to reproduce both issues:

  1. Create a user form, and add a Text Field to it
  2. Save the form/page
  3. Click the field type and change it to Dropdown Field
  4. Save the form/page

This works, and I'm assuming that's what @robbieaverill did while testing.

  1. Now click the edit button on the Dropdown Field.
  2. Click the Options tab
  3. Add a few options (don't save yet)

This still works, but now come the issues.

  1. Try adding a new option, and then deleting that option again
    The form refreshes, but the option doesn't get removed
  2. Clicking Save shows an error saying Not Found (might just be my setup)
  3. Using Save and Close works.

Now we're back on the form/page

  1. Open up the Dropdown Field again (it should go straight to the options tab)
  2. Now, refresh the page using the browser (F5 or refresh button or whatever)

We should still be on the options tab after the refresh, but:

  1. The browser console shows: TypeError: this.sortable is not a function
  2. Clicking Add throws a TypeError: this.getGridField is not a function error (in the browser console)

And finally the original issue here:

  1. Clicking the back button at the top left, and then changing the form type immediately shows the details page again (as described above by @chtombleson)

@robbieaverill
Copy link
Contributor

Closing as a duplicate of symbiote/silverstripe-gridfieldextensions#246

Thank you for the detailed steps to reproduce @Valandur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants