Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of standard link types #17

Closed
maxime-rainville opened this issue Nov 23, 2020 · 2 comments
Closed

Validation of standard link types #17

maxime-rainville opened this issue Nov 23, 2020 · 2 comments
Assignees

Comments

@maxime-rainville
Copy link

maxime-rainville commented Nov 23, 2020

Story

As a content author, I want LinkField to block me from inputting invalid data.

Acceptance criteria

  • Appropriate logic is applied - e.g. external links must have a URL, page links must have a Page, etc.
    • PageLink should have a page
    • EmailLink should have a valid email address
    • External link should have a valid full URL
    • Phone link should have a non blank string but not otherwise validate the phone number
    • File link should point to a valid CMS file.
  • We use form validation for validating the data.
  • The LinkField doc is updated to link to the form validation article in the main doc.

Exclude

Guy's PRs

Steve's PRs

@maxime-rainville
Copy link
Author

We have already partially implemented this in the process of re factoring bits of the linkfield.

Maybe this card just become a doc card.

@GuySartorelli
Copy link
Member

PRs merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants