Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sort caret with default SS styling #169

Open
2 tasks
brynwhyman opened this issue Feb 3, 2019 · 2 comments
Open
2 tasks

Replace sort caret with default SS styling #169

brynwhyman opened this issue Feb 3, 2019 · 2 comments

Comments

@brynwhyman
Copy link

brynwhyman commented Feb 3, 2019

The frontend table is using a sorting icon provided by Griddle.

This should be:

  • Replaced with the caret with provided with the Wātea theme something more in line with SS styling
  • Ensure the icon is always present on the column heading to highlight that the column is sort-able. (Griddle won't show the icon until the column heading is clicked)
@robbieaverill
Copy link
Contributor

Replaced with the caret provided with the Wātea theme

We should be careful not to couple it though. The theme isn't a dependency of this module.

@ScopeyNZ
Copy link
Contributor

ScopeyNZ commented Feb 4, 2019

Agreed. This issue should probably read "use default SS styling" or something. Preferably Wātea should not require any updates for this.

@brynwhyman brynwhyman changed the title Replace sort caret with Wātea styling Replace sort caret with default SS styling Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants