Revert "A couple renames" (only the big one)

This reverts commit 1b6840f.

Author: josephmyers

src/RealtimeServer/scriptureforge/models/question.ts

@@ -29,5 +29,5 @@ export interface Question extends ProjectData {
   dateArchived?: string;
   dateModified: string;
   dateCreated: string;
-  sourceQuestionId?: string;
+  transceleratorQuestionId?: string;
 }

src/RealtimeServer/scriptureforge/services/question-service.ts

@@ -187,7 +187,7 @@ export class QuestionService extends SFProjectDataService<Question> {
       dateCreated: {
         bsonType: 'string'
       },
-      sourceQuestionId: {
+      transceleratorQuestionId: {
         bsonType: 'string'
       }
     },

src/SIL.XForge.Scripture/ClientApp/src/app/checking/import-questions-dialog/import-questions-dialog.component.spec.ts

@@ -247,7 +247,7 @@ describe('ImportQuestionsDialogComponent', () => {
       verseNum: 1,
       verse: '1-3'
     });
-    expect(question.sourceQuestionId).toBe('2');
+    expect(question.transceleratorQuestionId).toBe('2');
   }));
 
   it('should properly import questions that are on a single verse', fakeAsync(() => {
@@ -891,7 +891,7 @@ class TestEnvironment {
       this.existingQuestions.push({
         data: {
           text: doc.text + ' [before edit]',
-          sourceQuestionId: doc.id,
+          transceleratorQuestionId: doc.id,
           answers: [] as Answer[],
           verseRef: fromVerseRef(new VerseRef(doc.book, doc.startChapter, verse))
         } as Question,
@@ -924,7 +924,7 @@ class TestEnvironment {
   static createQuestionDocWithSource(sourceId: string, verse: VerseRef, text: string): QuestionDoc {
     return {
       data: {
-        sourceQuestionId: sourceId,
+        transceleratorQuestionId: sourceId,
         verseRef: fromVerseRef(verse),
         text,
         answers: [] as Answer[]

src/SIL.XForge.Scripture/ClientApp/src/app/checking/import-questions-dialog/import-questions-dialog.component.ts

@@ -344,7 +344,7 @@ export class ImportQuestionsDialogComponent implements OnDestroy {
       const sfVersionOfQuestion: QuestionDoc | undefined = questionQuery.docs.find(
         doc =>
           doc.data != null &&
-          (useQuestionIds ? doc.data.sourceQuestionId === question.id : doc.data.text === question.text) &&
+          (useQuestionIds ? doc.data.transceleratorQuestionId === question.id : doc.data.text === question.text) &&
           toVerseRef(doc.data.verseRef).equals(question.verseRef)
       );
 
@@ -443,7 +443,7 @@ export class ImportQuestionsDialogComponent implements OnDestroy {
           isArchived: false,
           dateCreated: currentDate,
           dateModified: currentDate,
-          sourceQuestionId: listItem.question.id
+          transceleratorQuestionId: listItem.question.id
         };
         await this.zone.runOutsideAngular(() =>
           this.checkingQuestionsService.createQuestion(this.data.projectId, newQuestion, undefined, undefined)
@@ -521,7 +521,6 @@ export class ImportQuestionsDialogComponent implements OnDestroy {
       if (this.paratextTagOptions.length > 0) {
         this.selectedParatextTagId = this.paratextTagOptions[0].id;
       }
-      throw new Error();
     } catch (error) {
       console.error('Failed to load notes from Paratext: ', error);
       this.paratextNotes = [];

src/SIL.XForge.Scripture/Models/Question.cs

@@ -15,5 +15,5 @@ public class Question : ProjectData
     public DateTime? DateArchived { get; set; }
     public DateTime DateModified { get; set; }
     public DateTime DateCreated { get; set; }
-    public string SourceQuestionId { get; set; }
+    public string TransceleratorQuestionId { get; set; }
 }