Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Deleting audio files only removes the converted copy #1491

Closed
laineyhm opened this issue Sep 29, 2022 · 1 comment · Fixed by #1504
Closed

bug: Deleting audio files only removes the converted copy #1491

laineyhm opened this issue Sep 29, 2022 · 1 comment · Fixed by #1504
Assignees

Comments

@laineyhm
Copy link
Collaborator

laineyhm commented Sep 29, 2022

Describe the bug
When we record or upload audio, we save the original file and also save it as a FLEx-compatible file, of MP3 or WAV type. When we delete, we need to delete both files, not just one. Currently, only the converted file is being deleted.

To Reproduce
Steps to reproduce the behavior:

  1. Open the lf-app/var/www/assets/lexicon/[project-name]/audio Docker container.
  2. In Language Forge, (versions after pull request 1474), upload or record audio for an entry (don't upload an MP3 or WAV file for this). Notice two files for it saved in the container.
  3. In Language Forge, delete this audio from the entry.
  4. Notice that only the converted file was deleted from the container, and the original file is still there.

Expected behavior
Deleting audio from an entry/sense/example will delete all copies of that audio from the audio assets folder.

Screenshots
image
The top file got left behind when its audio was 'deleted' from Language Forge. The converted .wav file was deleted, but the recorded .webm file was not.

Desktop (please complete the following information):

  • OS: Windows 10, Mac OS 12.6
  • Browser Chrome 105

Additional context
See PR 1474: staging tests

@laineyhm laineyhm self-assigned this Sep 29, 2022
@laineyhm
Copy link
Collaborator Author

ALSO with this, replacing an audio file should delete file(s) that were in that entry before (if there are two, then both).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant