Skip to content

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 24, 2025

Fixes #843
Prequel to #3041

Building with CRA and a script file missing just has a console error. But the missing file causes a Parcel build to fail.


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Oct 24, 2025
@imnasnainaec imnasnainaec added the 🟨Medium Medium-priority PR label Oct 24, 2025
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Oct 24, 2025
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.30%. Comparing base (7218d23) to head (c860c93).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3960   +/-   ##
=======================================
  Coverage   74.30%   74.30%           
=======================================
  Files         292      292           
  Lines       10794    10794           
  Branches     1352     1352           
=======================================
  Hits         8021     8021           
  Misses       2387     2387           
  Partials      386      386           
Flag Coverage Δ
backend 85.45% <ø> (ø)
frontend 65.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 9b4f75b into master Oct 24, 2025
19 checks passed
@imnasnainaec imnasnainaec deleted the touch-public-scripts branch October 24, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file deployment docker frontend 🟨Medium Medium-priority PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uncaught SyntaxError in config.js / public/index.html in development build

3 participants