Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 10.1.19 - standardize webauthn initiation button #308

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Release 10.1.19 - standardize webauthn initiation button #308

merged 1 commit into from
Feb 6, 2025

Conversation

jason-jackson
Copy link
Contributor

@jason-jackson jason-jackson commented Feb 6, 2025 •
edited
Loading

IDP-1425

Fixed

  • Change OK button to use same text and formatting as other 2SV submit buttons

Notes

  • Oddly enough, there was no suggested change for Korean, so leaving it as is.

@jason-jackson jason-jackson requested a review from a team as a code owner February 6, 2025 17:37
@jason-jackson jason-jackson requested review from briskt, forevermatt, mtompset and hobbitronics and removed request for a team February 6, 2025 17:37
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jason-jackson jason-jackson merged commit 6a6b030 into main Feb 6, 2025
3 checks passed
@jason-jackson jason-jackson deleted the feature/standardize-webauthn-prompt branch February 6, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtompset mtompset mtompset left review comments

@devon-sil devon-sil devon-sil approved these changes

@briskt briskt Awaiting requested review from briskt briskt is a code owner automatically assigned from silinternational/php-devs

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/php-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jason-jackson @mtompset @devon-sil