Remove smartphone #307
Merged
Remove smartphone #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hobbitronics
requested review from
briskt,
forevermatt,
mtompset and
jason-jackson
and removed request for
a team
|
briskt
approved these changes
Feb 5, 2025
|
I believe it works better to merge the "parent" first. That is, the one that's merging into the main branch. In that way, each PR's description stays accurate to the commits within it. |
|
ahh, good point. I will have to remember to change the base next time when
I start another PR off of one.
…On Thu, Feb 6, 2025 at 11:50 AM briskt ***@***.***> wrote:
I believe it works better to merge the "parent" first. That is, the one
that's merging into the main branch. In that way, each PR's description
stays accurate to the commits within it.
—
Reply to this email directly, view it on GitHub
<#307 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQ34VP4DJXWKVU6XO2IVD2L2OLBFPAVCNFSM6AAAAABWP7ZJDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZYGYYTMNJWGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
--
*Michael Wilson*
Web Developer
GTIS ITSE
SIL International <https://www.sil.org>
***@***.***
*M:* 319-244-8359
*O:* 0493380960
Australian Central Time
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDP-24 Remove Smartphone check