Clear remember me from storage on submit and fix script path #304
Conversation
hobbitronics
requested review from
briskt,
forevermatt,
mtompset and
jason-jackson
and removed request for
a team
|
| const form = document.querySelector('form'); | ||
| if (form) { | ||
| form.addEventListener('submit', function() { | ||
| localStorage.removeItem('desiredRememberMeState'); |
There was a problem hiding this comment.
What's the reasoning behind clearing it? (I ask because I thought part of the goal was for it to stay how the user set it, even on subsequent logins, but that may have been in a separate YT issue.)
There was a problem hiding this comment.
So it will rely on the server side rememberMePreference cookie which I put in place earlier. The only issue is I think that will expire in 30 days possibly at the same time the rememberMe cookie expires so I could either remove the server side cookie and not remove this or I could set the expiration date later or indefinite. Any preference?
There was a problem hiding this comment.
I don't see any need for this to be done server-side (since I am not aware of us storing/using that preference anywhere server side), so I would lean towards just using the client-side local-storage option, with no expiration. I think that fits our goal better.
IDP-108 Keep "Remember me" unchecked if the user unchecks it (at least during a single login)