Wrap calls to ga check for analytics_tracking_id

[jason-jackson]

Changed

• Wrap calls to ga check for analytics_tracking_id

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[briskt]

Great job hunting down all the uses of ga!

[briskt]

I'm surprised ga is not defined since we should be providing the tracking ID in all IdPs. There may be something else wrong with the ga library.

[briskt]

I saw that @forevermatt marked GA as deprecated in idp-id-broker. Maybe he or @devon-sil can comment about its use here.

[jason-jackson]

I'm surprised ga is not defined since we should be providing the tracking ID in all IdPs. There may be something else wrong with the ga library.

Good question, maybe the ga commands need to be replaced with gtag commands? I'll look into this tomorrow.

[forevermatt]

I saw that @forevermatt marked GA as deprecated in idp-id-broker. Maybe he or @devon-sil can comment about its use here.

In ID Broker, I was deprecating the use of Google Analytics for reporting MFA metrics (server side, from a cron job). This all looks like client-side reporting, but I don't know if we still use that, either. 🤷

[mtompset]

I feel like @forevermatt wanting an abstraction to make the sense of these "is not empty" clearer, even though I know what it is.

[hobbitronics]

I am finding ga is undefined, but in header.twig gtag is defined and has a slightly different api which looks like:

      gtag('event', 'IdP', {
        'event_category': 'hub',
        'event_label': 'choice',
        'value': id
      });

[hobbitronics]

I think this should be

      gtag('event', 'IdP', {
        'event_category': 'hub',
        'event_label': 'choice',
        'value': id
      });