Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 10.1.2 -- null coalesce to prevent a type error #284

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Release 10.1.2 -- null coalesce to prevent a type error #284

merged 1 commit into from
Oct 10, 2024
+2 −2

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Oct 10, 2024 •
edited
Loading

IDP-1249 Clicking "Yes" when prompted to reset password (by expirychecker) triggers an error

Fixed

  • Add a null coalesce to prevent a type error.

@briskt briskt requested a review from a team as a code owner October 10, 2024 09:48
@briskt briskt requested review from forevermatt, mtompset, jason-jackson and hobbitronics and removed request for a team October 10, 2024 09:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@briskt briskt changed the title null coalesce to prevent a type error Release 10.1.2 -- null coalesce to prevent a type error Oct 10, 2024
hobbitronics
hobbitronics approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@briskt briskt merged commit 625a845 into main Oct 10, 2024
3 checks passed
@briskt briskt deleted the fix-idp-1249 branch October 10, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/php-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/php-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @hobbitronics