code was unreachable

silinternational · Sep 20, 2024 · c5243e3 · c5243e3
1 parent b919a42
commit c5243e3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/modules/mfa/public/prompt-for-mfa.php b/modules/mfa/public/prompt-for-mfa.php
@@ -32,6 +32,8 @@
 $cookieHash = filter_input(INPUT_COOKIE, 'c1') ?? ''; // hashed string
 $expireDate = filter_input(INPUT_COOKIE, 'c2') ?? 0;  // expiration timestamp
 if (Mfa::isRememberMeCookieValid(base64_decode($cookieHash), $expireDate, $mfaOptions, $state)) {
+    $idBrokerClient = Mfa::getIdBrokerClient($state['idBrokerConfig']);
+    $idBrokerClient->updateUserLastLogin($state['employeeId']);
     $logger->warning(json_encode([
         'event' => 'MFA skipped due to valid remember-me cookie',
         'employeeId' => $state['employeeId'],

diff --git a/modules/mfa/src/Auth/Process/Mfa.php b/modules/mfa/src/Auth/Process/Mfa.php
@@ -161,7 +161,7 @@ protected function getAttributeAllValues(string $attributeName, array $state): ?
      * @param array $idBrokerConfig
      * @return IdBrokerClient
      */
-    protected static function getIdBrokerClient(array $idBrokerConfig): IdBrokerClient|FakeIdBrokerClient
+    static function getIdBrokerClient(array $idBrokerConfig): IdBrokerClient|FakeIdBrokerClient
     {
         $clientClass = $idBrokerConfig['clientClass'];
         $baseUri = $idBrokerConfig['baseUri'];
@@ -701,8 +701,6 @@ public static function isRememberMeCookieValid(
                 $expectedString = self::generateRememberMeCookieString($rememberSecret, $state['employeeId'], $expireDate, $mfaOptions);
                 return password_verify($expectedString, $cookieHash);
             }
-        $idBrokerClient = self::getIdBrokerClient($state['idBrokerConfig']);
-        $idBrokerClient->updateUserLastLogin($state['employeeId']);
         }
 
         return false;