From 2a4eaaf946722b50c785e7514a4aab02a5b2b29f Mon Sep 17 00:00:00 2001 From: Michael Wilson Date: Fri, 31 Jan 2025 18:35:47 +0930 Subject: [PATCH 1/2] clear desiredRememberMeState on submit to not override cookie next time --- modules/mfa/public/remember-me.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/modules/mfa/public/remember-me.js b/modules/mfa/public/remember-me.js index 3683e3a8..90b50f9b 100644 --- a/modules/mfa/public/remember-me.js +++ b/modules/mfa/public/remember-me.js @@ -11,4 +11,11 @@ document.addEventListener('DOMContentLoaded', function() { localStorage.setItem('desiredRememberMeState', rememberMeCheckbox.checked); }); } + + const form = document.querySelector('form'); + if (form) { + form.addEventListener('submit', function() { + localStorage.removeItem('desiredRememberMeState'); + }); + } }); From 31f9206a8996bcf0f3e1231b55cefd16d46b0b8a Mon Sep 17 00:00:00 2001 From: Michael Wilson Date: Fri, 31 Jan 2025 18:51:32 +0930 Subject: [PATCH 2/2] fix broken url --- modules/mfa/public/prompt-for-mfa.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/mfa/public/prompt-for-mfa.php b/modules/mfa/public/prompt-for-mfa.php index 9d9038f3..c9511f4c 100644 --- a/modules/mfa/public/prompt-for-mfa.php +++ b/modules/mfa/public/prompt-for-mfa.php @@ -125,7 +125,7 @@ $t->data['mfa_options'] = $mfaOptions; $browserJsHash = md5_file(__DIR__ . '/simplewebauthn/browser.js'); $t->data['browser_js_path'] = '/module.php/mfa/simplewebauthn/browser.js?v=' . $browserJsHash; -$t->data['remember_me_js_path'] = '/module.php/mfa/public/remember-me.js'; +$t->data['remember_me_js_path'] = '/module.php/mfa/remember-me.js'; $t->data['manager_email'] = $state['managerEmail']; $t->data['other_options'] = $otherOptions; $t->data['idp_name'] = $t->getEntityDisplayName($state['IdPMetadata']);