Skip to content

Commit 342c05e

Browse files
committed
fix updateUserLastLogin is called regardless of the value of isValid.
1 parent 2d8f4dd commit 342c05e

File tree

1 file changed

+5
-3
lines changed
  • modules/mfa/src/Auth/Process

1 file changed

+5
-3
lines changed

modules/mfa/src/Auth/Process/Mfa.php

+5-3
Original file line numberDiff line numberDiff line change
@@ -700,9 +700,11 @@ public static function isRememberMeCookieValid(
700700
if ((int)$expireDate > time()) {
701701
$expectedString = self::generateRememberMeCookieString($rememberSecret, $state['employeeId'], $expireDate, $mfaOptions);
702702
$isValid = password_verify($expectedString, $cookieHash);
703-
704-
$idBrokerClient = self::getIdBrokerClient($state['idBrokerConfig']);
705-
$idBrokerClient->updateUserLastLogin($state['employeeId']);
703+
704+
if ($isValid) {
705+
$idBrokerClient = self::getIdBrokerClient($state['idBrokerConfig']);
706+
$idBrokerClient->updateUserLastLogin($state['employeeId']);
707+
}
706708

707709
return $isValid;
708710
}

0 commit comments

Comments
 (0)