chore(tests): async await instead of setTimeout #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
requested changes
Feb 26, 2022
Co-authored-by: Simen Bekkhus <[email protected]>
justinmchase
commented
Feb 27, 2022
CHANGELOG.md
Outdated
| @@ -27,13 +27,18 @@ project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| - The `processResources` metric was added, which keeps a track of all sorts of | |||
| active resources. It consists of the following gauges: | |||
|
|
|||
There was a problem hiding this comment.
I didn't add this line, for some reason the commit hook is adding it.
There was a problem hiding this comment.
probably prettier thinking the newline is... prettier 😀
SimenB
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a util/wait function and modified a test to use that instead of setTimeout.
This change is extracted from PR #495