add the ability to stop the event loop #495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're waiting for node to respond, maybe that could be pulled into a separate PR so we can land it? 🙂 |
…eature/histogram-stop
|
Merged with the other PR that broke out the change to the tests. Also, you probably don't need to wait for the node "unref" response since, even if they agree and add it, you'll still probably want a way to stop this as its reasonable to want to stop it without stopping the process. Also, if they do accept it it will likely go into node 17, in which case I'll have to wait for node 18 (lts) which could be years frankly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #494
Adds an optional "stop" function which when called will ultimately disable the histogram which will allow the node process to exit.
I also fixed a bug in the tests where a failed assertion in a setTimeout wasn't properly rejecting the test promise.