Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use perf_hooks monitorEventLoopDelay() instead of own monitoring #331

Closed
voxpelli opened this issue Feb 3, 2020 · 2 comments
Closed

Use perf_hooks monitorEventLoopDelay() instead of own monitoring #331

voxpelli opened this issue Feb 3, 2020 · 2 comments

Comments

@voxpelli
Copy link

voxpelli commented Feb 3, 2020

Since Node v11.10.0 Node.js has built in support for monitoring event loop delay: https://nodejs.org/api/perf_hooks.html#perf_hooks_perf_hooks_monitoreventloopdelay_options

I would suggest to use that rather than then current tracking:

const start = process.hrtime();
setImmediate(reportEventloopLag, start, gauge);

@SimenB
Copy link
Collaborator

SimenB commented Feb 3, 2020

This is being worked on in #278

@voxpelli
Copy link
Author

voxpelli commented Feb 3, 2020

Oh, my search skills failed me 🙈 Let’s close this one then

@voxpelli voxpelli closed this as completed Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants