Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: TUF contents are not saved to disk anymore #345

Closed
flavio opened this issue Apr 9, 2024 · 3 comments
Closed

Regression: TUF contents are not saved to disk anymore #345

flavio opened this issue Apr 9, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@flavio
Copy link
Member

flavio commented Apr 9, 2024

Description

Up to version 0.7.2, the SigstoreRepository::fetch method took care of synchronizing the contents of a local checkout of Sigstore's TUF repository.

Now (v0.8.0 being latest stable release), the SigstoreTrustRoot::new method tries to take advantage of a local cache of the TUF repository, but it doesn't update the local contents.

The code that takes care of synchronizing the local cache is still part of the sigstore-rs codebase, but it's no longer being used.

@flavio flavio added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Apr 9, 2024
@tnytown
Copy link
Contributor

tnytown commented Apr 9, 2024

Apologies for the regression. #311 reworks the target fetching functionality and caches the trust root correctly.

@flavio
Copy link
Member Author

flavio commented Apr 10, 2024

@tnytown no worries, ping me on the other PR when it's ready to be reviewed

@flavio
Copy link
Member Author

flavio commented Sep 17, 2024

Closing, this has been fixed

@flavio flavio closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants