Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confusing debug output in sign #564

Closed
jku opened this issue Mar 16, 2023 · 1 comment
Closed

confusing debug output in sign #564

jku opened this issue Mar 16, 2023 · 1 comment
Labels
good first issue Good for newcomers qa quality assurance

Comments

@jku
Copy link
Member

jku commented Mar 16, 2023

Signer.sign() does this:

logger.debug(f"cert-oidc-issuer: {oidc_identity.issuer}")

That makes it sound like I'm being shown the value that ends up as the signing certificate claim "Issuer" (1.3.6.1.4.1.57264.1.1), but I'm not as the printed value can be (and usually is) the sigstore dex proxy ("https://oauth2.sigstore.dev/auth").

Maybe the best solution is

  • debug print the oidc issuer f"oidc-issuer: {oidc_identity.issuer}"
  • as special case, if there is a federated issuer, print f"oidc-federated-issuer: {oidc_identity.connector_id}" (the connector_id is currently not exposed but that should be easy)

cc @lukpueh

@jku jku added the enhancement New feature or request label Mar 16, 2023
@woodruffw woodruffw added good first issue Good for newcomers qa quality assurance and removed enhancement New feature or request labels Apr 28, 2023
@woodruffw
Copy link
Member

I believe this is covered with #635!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers qa quality assurance
Projects
None yet
Development

No branches or pull requests

3 participants