Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keypair.SignData should except a Context parameter #426

Open
bdehamer opened this issue Mar 8, 2025 · 0 comments · May be fixed by #427
Open

Keypair.SignData should except a Context parameter #426

bdehamer opened this issue Mar 8, 2025 · 0 comments · May be fixed by #427
Labels
enhancement New feature or request

Comments

@bdehamer
Copy link
Collaborator

bdehamer commented Mar 8, 2025

Description

When building a Keypair implementation backed by a cloud HSM, it would be helpful if the SignData function accepted a Context for the current request.

This would allow for better retry/timeout support when interacting with the cloud HSM API.

Something like:

SignData(ctx context.Context, data []byte) ([]byte, []byte, error)

instead of the existing:

SignData(data []byte) ([]byte, []byte, error)
@bdehamer bdehamer added the enhancement New feature or request label Mar 8, 2025
@bdehamer bdehamer linked a pull request Mar 8, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant