Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifier does not enforce WithSignedCertificateTimestamps when the bundle is signed with a public key #403

Open
codysoyland opened this issue Feb 7, 2025 · 1 comment · May be fixed by #428
Labels
bug Something isn't working

Comments

@codysoyland
Copy link
Member

Description

func WithSignedCertificateTimestamps(threshold int) VerifierOption is used to specify a required threshold of SCTs present in the leaf certificate. This threshold is not enforced when the bundle is signed with a plain public key instead of a certificate. The check for SCTs is conditioned on the presence of a certificate. It should be an error to verify a bundle with a public key when the verifier is configured to require SCTs.

Version

@codysoyland codysoyland added the bug Something isn't working label Feb 7, 2025
@Horiodino
Copy link

/assign I’d like to work on this if it’s still available!

@Horiodino Horiodino linked a pull request Mar 9, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants