Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that io writers are properly closed. #292

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

wlynch
Copy link
Member

@wlynch wlynch commented Apr 18, 2023

Summary

Because the writers were being defered closed in New, this means that some files could be closed before we had the opportunity to write to them. This moves the close to their own func that can be ran in the correct place.

Partially fixes #291

Release Note

Fixed issue where debug log file was incorrectly closed to early.

Documentation

Because the writers were being defered closed in New, this means that
some files could be closed before we had the opportunity to write to
them. This moves the close to their own func that can be ran in the
correct place.

Signed-off-by: Billy Lynch <[email protected]>
@wlynch wlynch requested a review from cpanato April 18, 2023 15:07
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@wlynch wlynch merged commit 23df870 into sigstore:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Signing Git Commits with Keyless Github OIDC
2 participants