Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save MultiTrack in mp4 #72

Open
giorgiacantisani opened this issue Oct 14, 2020 · 4 comments
Open

Save MultiTrack in mp4 #72

giorgiacantisani opened this issue Oct 14, 2020 · 4 comments

Comments

@giorgiacantisani
Copy link

Hi!

I would like to modify the audio files in MUSDB and then save them again in the .mp4 format.
How can I do this? I noticed that this feature is not currently implemented (see save_estimates function in musdb).

So far, I tried with stempeg.write_stems function (https://github.com/faroit/stempeg) but I don't understand how to include the metadata.

Thank you very much

@faroit
Copy link
Member

faroit commented Oct 14, 2020

Hi @giorgiacantisani I am actually working on an reimplementation of the writing function. For now you can just follow this PR

faroit/stempeg#28

If you can't wait, have a look at: https://github.com/sigsep/sigsep-mus-io/blob/master/scripts/encode.sh

How can I do this? I noticed that this feature is not currently implemented (see save_estimates function in musdb).

Once finished, would you say it makes sense to offer stems writing from musdb as well?

@giorgiacantisani
Copy link
Author

Thank you very much for your suggestions!

I think it would definitely make sense. For example, in my case, I would like to modify the dataset and save again each MultiTrack object. In other cases, you may want to add some annotations or other metadata.

@faroit
Copy link
Member

faroit commented Dec 17, 2020

@giorgiacantisani stempeg 0.2.1 was just released and fully supports writing stems. how would you suggest to add this feature to musdb?

@giorgiacantisani
Copy link
Author

Hi! I suggest adding a save method to the class Multitrack so that you can load the tracks, modify and save them easily using the same object.
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants