Fix incorrect value set for blobs_by_root_request rpc limit.
#5181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanjay176
added
ready-for-merge
ethDreamer
approved these changes
Feb 5, 2024
Member
|
nice find jimmy :) @Mergifyio queue |
Member
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 8fa11aa |
5 tasks
danielrachi1
pushed a commit
to danielrachi1/lighthouse
that referenced
this pull request
Feb 14, 2024
…5181) * Fix incorrect value set for `blobs_by_root_request` rpc limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
The max rpc request size limit for
BlobSidecarsByRootis calculated using the max length forList<Hash256>, however the request content forBlobSidecarsByRootis a list ofBlobIdentifiers rather than a list of Roots.This PR fixes the calculation and increases the rpc request size limit.