[Merged by Bors] - Simplify GossipTopic -> String conversion #3722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
AgeManning
approved these changes
Nov 15, 2022
Member
AgeManning
left a comment
AgeManning
left a comment
There was a problem hiding this comment.
I guess you were looking at the logs for this change?
The other thing we need to be careful of is the metrics. I think most of the metrics may not use this, but I know in some of the dash's that we filter on the fork and use the specific topic string format.
Have you seen how the metrics behave after this change?
Member
Author
Nah, I just noticed that the |
AgeManning
approved these changes
Nov 15, 2022
Member
AgeManning
left a comment
AgeManning
left a comment
There was a problem hiding this comment.
Oh yeah, didn't look.
LGTM
michaelsproul
added
ready-for-merge
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 15, 2022
## Proposed Changes With a few different changes to the gossip topics in flight (light clients, Capella, 4844, etc) I think this simplification makes sense. I noticed it while plumbing through a new Capella topic.
bors
bot
changed the title
macladson
pushed a commit
to macladson/lighthouse
that referenced
this pull request
Jan 5, 2023
## Proposed Changes With a few different changes to the gossip topics in flight (light clients, Capella, 4844, etc) I think this simplification makes sense. I noticed it while plumbing through a new Capella topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
With a few different changes to the gossip topics in flight (light clients, Capella, 4844, etc) I think this simplification makes sense. I noticed it while plumbing through a new Capella topic.