Downgrade duplication log of attestation to Debug (#6007)

* Test

* Simplify

* summary_opt

* Simplify

* Test

* fix

* move to warn

* Revise

* Downgrade to debug

* Add block

* Put inside individual tracking

Author: chong-he

beacon_node/beacon_chain/src/validator_monitor.rs

@@ -1383,17 +1383,43 @@ impl<E: EthSpec> ValidatorMonitor<E> {
                 });
 
                 if self.individual_tracking() {
-                    info!(
-                        self.log,
-                        "Attestation included in aggregate";
-                        "head" => ?data.beacon_block_root,
-                        "index" => %data.index,
-                        "delay_ms" => %delay.as_millis(),
-                        "epoch" => %epoch,
-                        "slot" => %data.slot,
-                        "src" => src,
-                        "validator" => %id,
-                    );
+                    let is_first_inclusion_aggregate = validator
+                        .get_from_epoch_summary(epoch, |summary_opt| {
+                            if let Some(summary) = summary_opt {
+                                Some(summary.attestation_aggregate_inclusions == 0)
+                            } else {
+                                // No data for this validator: no inclusion.
+                                Some(true)
+                            }
+                        })
+                        .unwrap_or(true);
+
+                    if is_first_inclusion_aggregate {
+                        info!(
+                            self.log,
+                            "Attestation included in aggregate";
+                            "head" => ?data.beacon_block_root,
+                            "index" => %data.index,
+                            "delay_ms" => %delay.as_millis(),
+                            "epoch" => %epoch,
+                            "slot" => %data.slot,
+                            "src" => src,
+                            "validator" => %id,
+                        );
+                    } else {
+                        // Downgrade to Debug for second and onwards of logging to reduce verbosity
+                        debug!(
+                            self.log,
+                            "Attestation included in aggregate";
+                            "head" => ?data.beacon_block_root,
+                            "index" => %data.index,
+                            "delay_ms" => %delay.as_millis(),
+                            "epoch" => %epoch,
+                            "slot" => %data.slot,
+                            "src" => src,
+                            "validator" => %id,
+                        )
+                    };
                 }
 
                 validator.with_epoch_summary(epoch, |summary| {
@@ -1434,24 +1460,48 @@ impl<E: EthSpec> ValidatorMonitor<E> {
                         &["block", label],
                     );
                 });
-
                 if self.individual_tracking() {
                     metrics::set_int_gauge(
                         &metrics::VALIDATOR_MONITOR_ATTESTATION_IN_BLOCK_DELAY_SLOTS,
                         &["block", id],
                         delay.as_u64() as i64,
                     );
 
-                    info!(
-                        self.log,
-                        "Attestation included in block";
-                        "head" => ?data.beacon_block_root,
-                        "index" => %data.index,
-                        "inclusion_lag" => format!("{} slot(s)", delay),
-                        "epoch" => %epoch,
-                        "slot" => %data.slot,
-                        "validator" => %id,
-                    );
+                    let is_first_inclusion_block = validator
+                        .get_from_epoch_summary(epoch, |summary_opt| {
+                            if let Some(summary) = summary_opt {
+                                Some(summary.attestation_block_inclusions == 0)
+                            } else {
+                                // No data for this validator: no inclusion.
+                                Some(true)
+                            }
+                        })
+                        .unwrap_or(true);
+
+                    if is_first_inclusion_block {
+                        info!(
+                            self.log,
+                            "Attestation included in block";
+                            "head" => ?data.beacon_block_root,
+                            "index" => %data.index,
+                            "inclusion_lag" => format!("{} slot(s)", delay),
+                            "epoch" => %epoch,
+                            "slot" => %data.slot,
+                            "validator" => %id,
+                        );
+                    } else {
+                        // Downgrade to Debug for second and onwards of logging to reduce verbosity
+                        debug!(
+                            self.log,
+                            "Attestation included in block";
+                            "head" => ?data.beacon_block_root,
+                            "index" => %data.index,
+                            "inclusion_lag" => format!("{} slot(s)", delay),
+                            "epoch" => %epoch,
+                            "slot" => %data.slot,
+                            "validator" => %id,
+                        );
+                    }
                 }
 
                 validator.with_epoch_summary(epoch, |summary| {