Skip to content

Commit 77093d9

Browse files
authored
Merge of #7717
2 parents 538067f + 7f4acf9 commit 77093d9

File tree

1 file changed

+22
-18
lines changed

1 file changed

+22
-18
lines changed

beacon_node/beacon_chain/src/metrics.rs

Lines changed: 22 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1803,26 +1803,30 @@ pub static KZG_VERIFICATION_BATCH_TIMES: LazyLock<Result<Histogram>> = LazyLock:
18031803
"Runtime of batched kzg verification",
18041804
)
18051805
});
1806+
/// For reference on how the kzg data column verification buckets were set, here are some numbers for 48 blobs:
1807+
/// * 1 column batch: 5.76 ms
1808+
/// * 8 columns batch: 34.3 ms
1809+
/// * 64 columns batch: 257 ms
1810+
/// * 128 columns batch: 508 ms
18061811
pub static KZG_VERIFICATION_DATA_COLUMN_SINGLE_TIMES: LazyLock<Result<Histogram>> =
1807-
LazyLock::new(|| {
1808-
try_create_histogram_with_buckets(
1809-
"beacon_kzg_verification_data_column_single_seconds",
1810-
"Runtime of single data column kzg verification",
1811-
Ok(vec![
1812-
0.0005, 0.001, 0.0015, 0.002, 0.003, 0.004, 0.005, 0.007, 0.01, 0.02, 0.05,
1813-
]),
1814-
)
1815-
});
1812+
// 7 exponential buckets between 0.002 and 0.128 seconds, with more granularity on the lower end.
1813+
LazyLock::new(|| {
1814+
try_create_histogram_with_buckets(
1815+
"beacon_kzg_verification_data_column_single_seconds",
1816+
"Runtime of single data column kzg verification",
1817+
exponential_buckets(0.002, 2.0, 7),
1818+
)
1819+
});
18161820
pub static KZG_VERIFICATION_DATA_COLUMN_BATCH_TIMES: LazyLock<Result<Histogram>> =
1817-
LazyLock::new(|| {
1818-
try_create_histogram_with_buckets(
1819-
"beacon_kzg_verification_data_column_batch_seconds",
1820-
"Runtime of batched data column kzg verification",
1821-
Ok(vec![
1822-
0.002, 0.004, 0.006, 0.008, 0.01, 0.012, 0.015, 0.02, 0.03, 0.05, 0.07,
1823-
]),
1824-
)
1825-
});
1821+
// 10 exponential buckets between 0.002 and 1.024 seconds, with more
1822+
// granularity on the lower end.
1823+
LazyLock::new(|| {
1824+
try_create_histogram_with_buckets(
1825+
"beacon_kzg_verification_data_column_batch_seconds",
1826+
"Runtime of batched data column kzg verification",
1827+
exponential_buckets(0.002, 2.0, 10),
1828+
)
1829+
});
18261830

18271831
pub static BLOCK_PRODUCTION_BLOBS_VERIFICATION_TIMES: LazyLock<Result<Histogram>> = LazyLock::new(
18281832
|| {

0 commit comments

Comments
 (0)