Prevent silently dropping cell proof chunks (#8023)

Co-Authored-By: Eitan Seri- Levi <[email protected]>

Author: eserilev

beacon_node/beacon_chain/src/kzg_utils.rs

@@ -174,6 +174,13 @@ pub fn blobs_to_data_column_sidecars<E: EthSpec>(
     let kzg_commitments_inclusion_proof = block.message().body().kzg_commitments_merkle_proof()?;
     let signed_block_header = block.signed_block_header();
 
+    if cell_proofs.len() != blobs.len() * E::number_of_columns() {
+        return Err(DataColumnSidecarError::InvalidCellProofLength {
+            expected: blobs.len() * E::number_of_columns(),
+            actual: cell_proofs.len(),
+        });
+    }
+
     let proof_chunks = cell_proofs
         .chunks_exact(E::number_of_columns())
         .collect::<Vec<_>>();

beacon_node/http_api/src/publish_blocks.rs

@@ -412,7 +412,7 @@ fn build_data_columns<T: BeaconChainTypes>(
             error!(
                 error = ?e,
                 %slot,
-                "Invalid data column - not publishing block"
+                "Invalid data column - not publishing data columns"
             );
             warp_utils::reject::custom_bad_request(format!("{e:?}"))
         })?;

consensus/types/src/data_column_sidecar.rs

@@ -143,6 +143,7 @@ pub enum DataColumnSidecarError {
     PreDeneb,
     SszError(SszError),
     BuildSidecarFailed(String),
+    InvalidCellProofLength { expected: usize, actual: usize },
 }
 
 impl From<ArithError> for DataColumnSidecarError {