Enable notifier and latency service #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CK's dvt changes - Remove `sign_validator_exit` from trait
…as "SigningEnabled"
|
|
Merged
# Conflicts: # Cargo.lock # Cargo.toml # anchor/client/src/lib.rs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enables the notifier and latency services to improve the client's functionality related to validator notifications and latency measurements. Key changes include updating the validator store to use a filter function for selecting voting public keys, integrating the notifier and latency services in the client, and adding a configuration flag along with a CLI option to control the latency service.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| anchor/validator_store/src/lib.rs | Updates voting_pubkeys to filter validators by status |
| anchor/client/src/lib.rs | Activates notifier and latency services with error handling for notifier only |
| anchor/client/src/config.rs | Adds a new flag and default for latency service control |
| anchor/client/src/cli.rs | Adds a CLI flag to disable the latency measurement service |
# Conflicts: # anchor/client/src/lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Proposed Changes
Additional Info
We can merge this as soon as I tested the changes and we have merged the LH changes into the
anchorbranch.