Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

user question - nba api #71

Open
startakovsky opened this issue Feb 23, 2017 · 8 comments
Open

user question - nba api #71

startakovsky opened this issue Feb 23, 2017 · 8 comments

Comments

@startakovsky
Copy link
Contributor

startakovsky commented Feb 23, 2017

When I run the setup_env.sh in the sigopt beats vegas module, it just says "downloading season 1" and doesn't do anything. Are there any common problems that arise executing this?

@startakovsky
Copy link
Contributor Author

The issue you're seeing is from the ./sigopt-beats-vegas/boxscores/scraper/srape_all script. The logic for the scraping is in the scraper.py module and nba.com regularly updates their API so that is likely the problem you're seeing.

While we do not regularly keep this example up-to-date, we encourage Pull Requests from the greater community.

@kevintee
Copy link

Ran into the same problem, this really helped!

@alexandraj777
Copy link
Contributor

Can we close this issue?

@alexandraj777
Copy link
Contributor

Should we add comments to the readme maybe and resolve?

@dlman
Copy link

dlman commented May 17, 2017

Ran into same problem, should fix or at least put into readme.

@dlman
Copy link

dlman commented May 17, 2017

Actually tried to fix the scraper code, apparently the stats.nba pages uses a different URL and also the content within the page is js injected, so requests doesn't pull any of the stats, may need to use something else like selenium. May take a stab at it later.

@alexandraj777
Copy link
Contributor

The real solution here might be for us to take the original dataset and load it into a publicly available bucket on s3 :)
Then the scraper is available for the curious but we don't run into so many web scraping issues

@dlman
Copy link

dlman commented May 17, 2017

Sounds like a plan!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants