Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Detectors prorogate bugs that have long been fixed by opentelemtry-js #923

Closed
davemyers-dev opened this issue Jul 22, 2024 · 1 comment

Comments

@davemyers-dev
Copy link

The resource detectors that were copied into this library, seemingly to work around an sync issue which was also fixed a year ago, continue to propagate issues that open telemetry has already fixed in their source.

All of Otel's source detectors have been updated since they were copied.

Ex of a bug only present in this wrapper as a result:
open-telemetry/opentelemetry-js#3295

Otel also made changes to allow synchronous detectors in open-telemetry/opentelemetry-js#2912. This may mean that these do not need to be copied into this library at all.

Proposals:
Copied detectors should be removed from this library
or
Copied code should be properly maintained and updated with latest from source

@seemk
Copy link
Contributor

seemk commented Jul 30, 2024

With #925 detectors have been switched to upstream ones (with the exception of container detector).

However do note that spaces in resource attribute values need to be encoded as %20, see open-telemetry/opentelemetry-js#3131

E.g.
export OTEL_RESOURCE_ATTRIBUTES='service.name="foo bar"'
needs to be written as
export OTEL_RESOURCE_ATTRIBUTES='service.name="foo%20bar"'

@seemk seemk closed this as completed Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants