Add trafficDistribution support to the gateway and agent services#1874
Conversation
e30ed1d to
8da9cb7
Compare
There was a problem hiding this comment.
Can you add this config in one of our examples? Tmk, this config is only introduced in a recent version of k8s and i think kubeconform output would shed some light on version support for this. I think this might require a note or check for min k8s version
8da9cb7 to
54478fd
Compare
Apparently it's only available since 1.33 and our tests are still at 1.31. So adding it to examples would be failing. I added a note in the comments |
54478fd to
b9c9d82
Compare
| {{- end }} | ||
| spec: | ||
| type: {{ .Values.service.type }} | ||
| {{- if .Values.service.trafficDistribution }} |
There was a problem hiding this comment.
| {{- if .Values.service.trafficDistribution }} | |
| {{- if and .Values.service.trafficDistribution (semverCompare ">=1.33.0-0" .Capabilities.KubeVersion.Version) }} |
We could additionally verify in template but the clarification in comment is also good with me.
There was a problem hiding this comment.
I think it's fine to fail rather then suppressing the user error.
Replaces #1772