Skip to content

Add trafficDistribution support to the gateway and agent services#1874

Merged
dmitryax merged 1 commit into
mainfrom
add-trafficDistribution
Jul 2, 2025
Merged

Add trafficDistribution support to the gateway and agent services#1874
dmitryax merged 1 commit into
mainfrom
add-trafficDistribution

Conversation

@dmitryax

Copy link
Copy Markdown
Contributor

Replaces #1772

@dmitryax dmitryax requested review from a team as code owners June 25, 2025 22:11
@dmitryax dmitryax force-pushed the add-trafficDistribution branch from e30ed1d to 8da9cb7 Compare June 25, 2025 22:17

@jinja2 jinja2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this config in one of our examples? Tmk, this config is only introduced in a recent version of k8s and i think kubeconform output would shed some light on version support for this. I think this might require a note or check for min k8s version

Comment thread helm-charts/splunk-otel-collector/values.yaml Outdated
@dmitryax dmitryax force-pushed the add-trafficDistribution branch from 8da9cb7 to 54478fd Compare June 29, 2025 04:38
@dmitryax

dmitryax commented Jun 29, 2025

Copy link
Copy Markdown
Contributor Author

Can you add this config in one of our examples? Tmk, this config is only introduced in a recent version of k8s and i think kubeconform output would shed some light on version support for this. I think this might require a note or check for min k8s version

Apparently it's only available since 1.33 and our tests are still at 1.31. So adding it to examples would be failing. I added a note in the comments

@dmitryax dmitryax force-pushed the add-trafficDistribution branch from 54478fd to b9c9d82 Compare June 29, 2025 04:40
{{- end }}
spec:
type: {{ .Values.service.type }}
{{- if .Values.service.trafficDistribution }}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{- if .Values.service.trafficDistribution }}
{{- if and .Values.service.trafficDistribution (semverCompare ">=1.33.0-0" .Capabilities.KubeVersion.Version) }}

We could additionally verify in template but the clarification in comment is also good with me.

@dmitryax dmitryax Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to fail rather then suppressing the user error.

@dmitryax dmitryax merged commit 3aecacf into main Jul 2, 2025
159 of 161 checks passed
@dmitryax dmitryax deleted the add-trafficDistribution branch July 2, 2025 21:50
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants