Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoggingSpanExporter should be opt-in #893

Closed
breedx-splk opened this issue Aug 6, 2024 · 0 comments · Fixed by #894
Closed

LoggingSpanExporter should be opt-in #893

breedx-splk opened this issue Aug 6, 2024 · 0 comments · Fixed by #894

Comments

@breedx-splk
Copy link
Contributor

With the core of the sdk moving to otel, upstream currently defaults to using the LoggingSpanExporter as the exporter. We want span logging to be disabled by default, so this shouldn't be the case in our distro.

For a few reasons, we don't yet replace the upstream exporter, but instead inject our own BatchSpanProcessor, which has its own exporter. One option, if we continue to do this, is to omit the upstream exporter with a no-op exporter (or similar).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant